Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project status/passing action to notify callback #20

Closed
MattKunze opened this issue Jan 20, 2017 · 2 comments
Closed

Project status/passing action to notify callback #20

MattKunze opened this issue Jan 20, 2017 · 2 comments

Comments

@MattKunze
Copy link

I see there are three open PRs for passing the action being dispatched to the notify callback (#6, #13, #17) - any updates about your thoughts regarding a change like that?

This enhancer gives us great perf wins for our application, but there are a handful of actions dispatched by keyboard input that we need to notify subscribers immediately or things get laggy and cause other input issues.

Please don't take this as being critical or nagging, I know everyone is busy and OSS projects can easily become time sinks, I'm just looking to see whether I should maintain a separate fork or your goals are to continue maintaining this project.

@tappleby
Copy link
Owner

I havent had time recently to focus on this project but I plan on getting back to it soon.

I had originally not wanted to add support for passing the action to the notify callback because it deviated from how subscribe handlers currently work.

After thinking about it some more and looking at the number of requests + forks, I think its a good thing to have.

@MattKunze
Copy link
Author

Thanks for the reply. I'll watch for updates and switch back to main version once something like that lands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants