Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 15, --ts has no effect #736

Closed
midgleyc opened this issue Apr 5, 2021 · 1 comment
Closed

In 15, --ts has no effect #736

midgleyc opened this issue Apr 5, 2021 · 1 comment

Comments

@midgleyc
Copy link

midgleyc commented Apr 5, 2021

I appreciate that this a major release, but I couldn't see anything in the release notes that I should change to fix this. I see that typescript support is now disabled by default, but I should still be able to enable it, right?

An example run is at https://github.com/midgleyc/east-mysql2/pull/50/checks?check_run_id=2269679406

The project uses typescript, and has typescript installed. On tap 14, running "npx tap --ts" compiled and ran the tests; on tap 15 I get the error:

SyntaxError: Cannot use import statement outside a module

It appears that the tests are not being compiled.

Running an individual test with npx ts-node tests/connect-params.ts still works.

To run all the tests, I can use npx tap --node-arg="-r" --node-arg="ts-node/register" -- this works whether or not --ts is present. It always finds the .ts files and does not compile them.

@midgleyc midgleyc changed the title npx tap fails on 15 but works on 14 for east-mysql2 project In 15, --ts has no effect Apr 5, 2021
@isaacs
Copy link
Member

isaacs commented Apr 5, 2021

Ah, it was only loading typescripts when --jsx was specified. Fixed in 15.0.2.

@isaacs isaacs closed this as completed in 32e45eb Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants