track thrown error when timeout/throws happen during promise waiting

tapjs · Sep 23, 2019 · 6a4d64b · 6a4d64b
1 parent 5b977e1
commit 6a4d64b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/test.js b/lib/test.js
@@ -346,7 +346,7 @@ class Test extends Base {
   timeout (options) {
     options = options || {}
     options.expired = options.expired || this.name
-    if (this.occupied)
+    if (this.occupied && this.occupied.timeout)
       this.occupied.timeout(options)
     else
       Base.prototype.timeout.call(this, options)
@@ -867,7 +867,10 @@ class Test extends Base {
     // threw while waiting for a promise to resolve.
     // probably it's not ever gonna.
     if (this.occupied && this.occupied instanceof Waiter)
-      this.occupied.abort(new Error('error thrown while awaiting Promise'))
+      this.occupied.abort(Object.assign(
+        new Error('error thrown while awaiting Promise'),
+        { thrown: er }
+      ))
 
     this.process()
   }

diff --git a/tap-snapshots/test-test.js-TAP.test.js b/tap-snapshots/test-test.js-TAP.test.js
@@ -3203,6 +3203,12 @@ TAP version 13
         message: error thrown while awaiting Promise
         stack: |
           {STACK}
+        thrown:
+          !error
+          name: Error
+          message: poop
+          stack: |
+            {STACK}
       source: |2
             setTimeout(() => t.threw(new Error('poop')))
             return t.resolveMatch(() => new Promise(() => {}), 'never resolves')