Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KameraWriter_Final #2

Open
borg opened this issue Jul 1, 2015 · 1 comment
Open

KameraWriter_Final #2

borg opened this issue Jul 1, 2015 · 1 comment

Comments

@borg
Copy link

borg commented Jul 1, 2015

In KameraWriter_Final I found
self.captureSession.sessionPreset = [self sessionPreset];

did in fact not take effect, where as
[self.captureSession setSessionPreset:AVCaptureSessionPresetInputPriority];

did. Not sure why the return value didn't work, maybe missing const?

Also, it is worth adding support for check for

if(![videoDevice supportsAVCaptureSessionPreset:AVCaptureSessionPreset1280x720]){
 NSDictionary *userInfo = @{NSLocalizedDescriptionKey : @"Camera does not support session preset"};
        *error = [NSError errorWithDomain:THCameraErrorDomain
                                     code:THCameraErrorFailedToAddInput
                                 userInfo:userInfo];
        return NO;
}

as the front camera on an iPad2 for instance fails without throwing an error.

@bobmccune
Copy link
Member

Thanks for the heads up! I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants