-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] deepEqual breaking change v5.0.0 #508
Comments
v5.0.0 is a semver-major, breaking changes are expected. Setting strict is not "wrong", it matches what node has done since like v4. If you want loose equality, use https://github.com/substack/tape#tdeeplooseequalactual-expected-msg; if you're curious to know why those two objects are considered different, i'd try |
I didn't see |
With version 5.0.0 all my deepEqual fails. The reason is: d26c6a0#diff-dd2e881af3311f834199c7b515cff0c7R501
Here you set
strict:true
but that's wrong because with that test like this will fail:The text was updated successfully, but these errors were encountered: