Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid gold query for document_management #97

Open
philipandersson opened this issue Oct 19, 2023 · 3 comments
Open

Invalid gold query for document_management #97

philipandersson opened this issue Oct 19, 2023 · 3 comments

Comments

@philipandersson
Copy link

Thanks @taoyds for doing amazing job putting together such an extensive dataset & benchmark for NL-to-SQL models!

Unfortunately I've run into some issues trying to run the official Test Suite Accuracy evaluator on the Spider dataset.

Apart from the issue #78, I've found the following gold query from train_spider.json not being compatible with sqlite :

SELECT document_name FROM documents GROUP BY document_type_code ORDER BY count(*) DESC LIMIT 3 INTERSECT SELECT document_name FROM documents GROUP BY document_structure_code ORDER BY count(*) DESC LIMIT 3

Is this intended? If not, I could open a PR to reorder the ORDER BY clause to come after INTERSECT to solve this.

How to reproduce:

> sqlite3 ./spider/database/document_management/document_management.sqlite 
SQLite version 3.39.5 2022-10-14 20:58:05
Enter ".help" for usage hints.
sqlite> SELECT document_name FROM documents GROUP BY document_type_code ORDER BY count(*) DESC LIMIT 3 INTERSECT SELECT document_name FROM documents GROUP BY document_structure_code ORDER BY count(*) DESC LIMIT 3;
Parse error: ORDER BY clause should come after INTERSECT not before
@philipandersson
Copy link
Author

I know you are probably busy @taoyds but I would appreciate your input here!

@philipandersson
Copy link
Author

@ygan @danielhers 🙏🏼

@BugMaker-Boyan
Copy link

struggle with same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants