fix: blockTextElements incorrectly matching partial tag (detail) (fixes

#156 fixes #124) Tags 'premises' is matched as 'pre', 'pstyle' as 'style', etc.
taoqf · Oct 10, 2021 · 6823349 · 6823349
1 parent 9a9226c
commit 6823349
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/nodes/html.ts b/src/nodes/html.ts
@@ -1019,8 +1019,8 @@ export function base_parse(data: string, options = { lowerCaseTagName: false, co
 		pre: true,
 	};
 	const element_names = Object.keys(elements);
-	const kBlockTextElements = element_names.map((it) => new RegExp(it, 'i'));
-	const kIgnoreElements = element_names.filter((it) => elements[it]).map((it) => new RegExp(it, 'i'));
+	const kBlockTextElements = element_names.map((it) => new RegExp(`^${it}$`, 'i'));
+	const kIgnoreElements = element_names.filter((it) => elements[it]).map((it) => new RegExp(`^${it}$`, 'i'));
 
 	function element_should_be_ignore(tag: string) {
 		return kIgnoreElements.some((it) => it.test(tag));

diff --git a/test/pre.js b/test/pre.js
@@ -1,4 +1,5 @@
 const { parse } = require('../dist');
+const { HTMLElement } = require('../dist');
 
 // https://github.com/taoqf/node-html-parser/issues/77
 describe('pre tag', function () {
@@ -51,4 +52,10 @@ describe('pre tag', function () {
 		const code = pre.firstChild;
 		code.childNodes.length.should.eql(11);
 	});
+	// see: https://github.com/taoqf/node-html-parser/issues/156
+	it('does not treat pre* tag as pre (partial match)', () => {
+    const docRoot = parse("<premises><color>Red</color></premises>");
+    Object.getPrototypeOf(docRoot.firstChild.firstChild).should.eql(HTMLElement.prototype);
+    docRoot.firstChild.firstChild.tagName.should.eql('COLOR');
+  })
 });