fix(query-cache): Prevent re-run of query for refetch interval if update is disabled #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f update is disabled
tannerlinsley
requested changes
Jun 26, 2020
src/core/queryCache.js
Outdated
| instance => instance.config.refetchIntervalInBackground | ||
| instance => | ||
| instance.config.refetchIntervalInBackground && | ||
| instance.config.enabled |
There was a problem hiding this comment.
This check needs to happen before the is document visible. If the query doesn’t have an enabled instance, then we should never even reach these other conditions.
tannerlinsley
approved these changes
Jun 27, 2020
|
🎉 This PR is included in version 2.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue: #635.