Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why limit file contents to just strings? #6

Open
danielo515 opened this issue Sep 1, 2021 · 0 comments · May be fixed by #7
Open

Why limit file contents to just strings? #6

danielo515 opened this issue Sep 1, 2021 · 0 comments · May be fixed by #7

Comments

@danielo515
Copy link

danielo515 commented Sep 1, 2021 •
edited
Loading

Hello.
I have a situation where I want to zip a buffer that contains binary data.
I tested the file with the underlying library (zip-stream) and it works correctly without problem. However, you only accept strings as input, and your library deletes any content that is not a string:

express-easy-zip/index.js

Lines 82 to 83 in a2bed82

return new Promise(function(resolve, reject) {
data = clean.cleanOnlyString(data);

Why this limitation when the zip-stream library is capable of handling Buffer | Stream | String?
@danielo515 danielo515 linked a pull request Sep 1, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept String and Buffer as file content danielo515/express-easy-zip
1 participant
@danielo515