Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickering on first zoom out after clearing map data layer #2133

Open
westnordost opened this issue Jan 20, 2020 · 4 comments
Open

Flickering on first zoom out after clearing map data layer #2133

westnordost opened this issue Jan 20, 2020 · 4 comments
Assignees

Comments

@westnordost
Copy link
Contributor

westnordost commented Jan 20, 2020

Summary
Zooming in and out usually looks smooth. However, if you clear a map data layer while being zoomed in, the first time you zoom out again will lead to flickering of the features in the map data layer that should have been cleared.

It looks as if the features in the map data layer have not been cleared yet on the different zoom levels and are so only when first entering that zoom level.
I did not test whether this bug only occurs when clearing a map data layer or also when setting (different) features on it.

Video here: https://www.westnordost.de/misc/tangram-flicker-2133.mp4

Reproduction

  • add a map data layer via MapController.addDataLayer and add a geometry to it
  • Zoom in
  • Clear the map data layer
  • Zoom out. Doesn't matter if manually via gesture or with an animation.

Result
The cleared features in the map data layer flicker on zooming out.

Expected result
They do not flicker but are gone right away.

Environment
Tangram Version 0.11.2
Tested on Android Version 5.1.2
Tested on Sony Xperia Z1 Compact

@matteblair
Copy link
Member

Just a clarification: in #2131 it sounded like this started in version 0.12.0, is that the case?

@westnordost
Copy link
Contributor Author

westnordost commented Jan 22, 2020 via email

@tallytalwar
Copy link
Member

tallytalwar commented Jan 24, 2020

Seems like a consequence of the changes as part of #2118, possible proxy tiles are holding onto this data. If I understand this correctly, @matteblair I might steal assignee from you.

@RubenKelevra
Copy link

I just want to throw in an example how it looks like, running on Android 9:

https://youtu.be/NYgtkI5tU7U

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants