Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FixedDepositAnchor contract, update contracts, and update ethers-rs #75

Merged
merged 4 commits into from
Aug 1, 2022
Merged

Remove FixedDepositAnchor contract, update contracts, and update ethers-rs #75

merged 4 commits into from
Aug 1, 2022

Conversation

shekohex
Copy link
Collaborator

@shekohex shekohex commented Aug 1, 2022

Closes #74

shekohex
shekohex commented Aug 1, 2022
View reviewed changes
proposals/Cargo.toml
scale-info = { version = "2.1.1", default-features = false, optional = true }

num-traits = { version = "0.2.8", default-features = false }
typed-builder = { version = "0.10.0", default-features = false, optional = true }
tiny-keccak = { version = "2.0.0", features = ["keccak"] }
cosmwasm-std = { version = "1.0.0", default-features = false, optional = true }
cosmwasm-std = { version = "1.0.0", default-features = false, optional = true, git = "https://github.com/CosmWasm/cosmwasm.git" }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once CosmWasm/cosmwasm#1374 publish a new version of cosmwasm-std we will remove the usage of git repo here.

@shekohex shekohex self-assigned this Aug 1, 2022
@shekohex shekohex added feature ➕ Tasks that are functional additions or enhancements needs review 👓 Pull request needs a review optimization ⚙️ Tasks that are refactor, optimize, or are considered chores. labels Aug 1, 2022
drewstone
drewstone requested changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we remove the AnchorProxy as well? That contract is tied to FixedDepositAnchor too @shekohex

@shekohex
Copy link
Collaborator Author

shekohex commented Aug 1, 2022

LGTM, can we remove the AnchorProxy as well? That contract is tied to FixedDepositAnchor too @shekohex

Done.

@shekohex shekohex merged commit 7bf0553 into main Aug 1, 2022
@shekohex shekohex removed the needs review 👓 Pull request needs a review label Aug 1, 2022
@shekohex shekohex deleted the shady/remove-fixed-deposit-anchor branch August 1, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone requested changes

Assignees

@shekohex shekohex

Labels
feature ➕ Tasks that are functional additions or enhancements optimization ⚙️ Tasks that are refactor, optimize, or are considered chores.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Remove Fixed Deposit Anchor and Update Contracts
2 participants
@shekohex @drewstone