Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results should include browser name #1

Closed
stanislavgeorgiev opened this issue Dec 9, 2016 · 3 comments
Closed

Results should include browser name #1

stanislavgeorgiev opened this issue Dec 9, 2016 · 3 comments
Assignees

Comments

@stanislavgeorgiev
Copy link

Hi, I like the plugin and it's just the thing I needed. However, I'm running tests in Chrome and IE and the results file doesn't include the browser in which the test was run in:

{
    "errors": [],
    "results": [
        {
            "description": "should say Hello to the World",
            "id": "spec0",
            "log": [],
            "skipped": false,
            "success": true,
            "suite": [
                "greeter"
            ],
            "time": 0,
            "executedExpectationsCount": 1
        },
        {
            "description": "should say Hello to the World",
            "id": "spec0",
            "log": [],
            "skipped": false,
            "success": true,
            "suite": [
                "greeter"
            ],
            "time": 2,
            "executedExpectationsCount": 1
        }
    ]
}
@tanenbaum
Copy link
Owner

I'm glad you're finding it useful.

You're absolutely right, it does need results sets per browser. I was using it primarily for single phantom runs so it hadn't occurred to me.

It won't be difficult to accomplish. Do you have a schema in mind?

@tanenbaum tanenbaum self-assigned this Dec 10, 2016
@tanenbaum
Copy link
Owner

JSON output changed to be browser centric in v1.0.0.

@stanislavgeorgiev
Copy link
Author

Hey, no worries and thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants