Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Ruff configuration file reports schema error #536

Closed
ssteinerx opened this issue Jan 22, 2024 · 3 comments
Closed

Default Ruff configuration file reports schema error #536

ssteinerx opened this issue Jan 22, 2024 · 3 comments

Comments

@ssteinerx
Copy link

Ruff config gives a .toml file that is equivalent to the default configuration.

The error reported is:

{"quote-style":"double","indent-style":"space","skip-magic-trailing-comma":false,"line-ending":"auto","docstring-code-format":false,"docstring-code-line-length":"dynamic"} is not valid under any of the given schemas

I don't know enough about toml schema to know who's right but it seems unlikely that Ruff would provide an invalid configuration for their tool...considering what the tool is for.

@ia0
Copy link
Collaborator

ia0 commented Jan 22, 2024

Thanks for the issue, however this is not a problem in Taplo but in the Ruff schema. I guess Ruff updated something on their side that didn't get reflected in the JSON schema. There's actually an issue is SchemaStore to link directly to the source of truth in Ruff but it seems not technically possible yet: SchemaStore/schemastore#2731. Feel free to open an issue (or a PR) to SchemaStore and link it here for future people. I'm closing this issue.

@ia0 ia0 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2024
@austinmw
Copy link

austinmw commented Jul 22, 2024

I'm still geting similar Even Better TOML warnings:

[tool.ruff]  # https://github.com/charliermarsh/ruff
fix = true
line-length = 100
src = ["src", "tests"]
target-version = "py311"
exclude = ["./concordia"]

[tool.ruff.lint]
ignore-init-module-imports = true
select = ["A", "ASYNC", "B", "C4", "C90", "D", "DTZ", "E", "F", "FLY", "FURB", "I", "ISC", "LOG", "N", "NPY", "PERF", "PGH", "PIE", "PL", "PT", "Q", "RET", "RUF", "RSE", "SIM", "TID", "UP", "W", "YTT"]
ignore = ["D203", "D213", "E501", "PGH002", "PGH003", "RET504", "S101", "S307"]
unfixable = ["F401", "F841"]

[tool.ruff.lint.flake8-tidy-imports]
ban-relative-imports = "all"

[tool.ruff.lint.pydocstyle]
convention = "numpy"

{"ignore-init-module-imports":true,"select":["A","ASYNC","B","C4","C90","D","DTZ","E","F","FLY","FURB","I","ISC","LOG","N","NPY","PERF","PGH","PIE","PL","PT","Q","RET","RUF","RSE","SIM","TID","UP","W","YTT"],"ignore":["D203","D213","E501","PGH002","PGH003","RET504","S101","S307"],"unfixable":["F401","F841"],"flake8-tidy-imports":{"ban-relative-imports":"all"},"pydocstyle":{"convention":"numpy"}} is not valid under any of the given schemas Even Better TOML

Where's the correct place to create an issue for this?

@panekj
Copy link
Collaborator

panekj commented Jul 22, 2024

Where's the correct place to create an issue for this?

https://github.com/SchemaStore/schemastore/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants