Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac: only enable use mmove hook when a mouse button is actually pressed #974

Closed
lunixbochs opened this issue Sep 10, 2022 · 4 comments
Closed
Assignees
Labels
help wanted Extra attention is needed MacOS Affects and needs testing on MacOS question Further information is requested

Comments

@lunixbochs
Copy link
Collaborator

lunixbochs commented Sep 10, 2022

The MMOVE tap/hook here causes Talon to waste CPU when the user moves their mouse without buttons pressed: https://github.com/knausj85/knausj_talon/blob/main/code/mouse.py#L387-L400

You can probably get away with leaving it unregistered by default, and only register it between the drag and release commands.

@lunixbochs lunixbochs added the MacOS Affects and needs testing on MacOS label Sep 10, 2022
@nriley nriley self-assigned this Sep 17, 2022
@nriley
Copy link
Collaborator

nriley commented Sep 18, 2022

I was able to comment out this tap usage entirely and dragging seemed to still work with an eye tracker. I was able to drag both with the left mouse button and with the right mouse button (mostly doesn't do anything different but it does in Excel), using 'drag'/'end drag' and 'right drag'/'end drag'.

@knausj85, looks like this was your change (e31ac72). Any idea what problem it was trying to fix, and if this is still a problem?

@nriley nriley added the help wanted Extra attention is needed label Sep 18, 2022
@nriley nriley added the question Further information is requested label Oct 15, 2022
@knausj85
Copy link
Member

This was to fix dragging windows so the window moved with the cursor. I don't believe it does anything on Big Sur or later though.

@nriley
Copy link
Collaborator

nriley commented Oct 23, 2022

OK, think we can just remove it then, or would it make sense to make it conditional on macOS version? I don't have a 10.15 Mac any more.

@knausj85
Copy link
Member

#1093 addressed this by removing the tap code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed MacOS Affects and needs testing on MacOS question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants