-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secrets support #1480
Comments
Do we have support for |
Ah interesting. 1Password api might be interesting to consider as well |
Agreed, seems like we would be best off with something pluggable, where I tested and there does not seem to be a |
There's the 1Password CLI, but first use has a permission prompt, so would be annoying if you don't have biometric auth (since we don't have async Talon actions). |
It would be useful to have a standard mechanism for secrets storage. Something like the following
I guess they could have type other than
str
for the value but might be easiest to just use strings as we wouldn't actually know the type statically anywayThere are different ways we could actually register / define the secrets. I personally keep my secrets in a directory called
~/envs
, with read/write access only for my user, and where each subdirectory corresponds to the secrets for one service. EgSo if we wanted to support this kind of setup, we could allow user to have a setting eg
Basically just a comma-separated list of directories, and any files in there will be read, and result in a secret whose
name
is the name of the file and whose value is the contents of the file, stripped of leading and trailing whitespaceBut we could support multiple ways of actually defining the secrets, and they could all probably just register the secrets via the same
user.secrets_set(...)
api on Talon startupThis would be useful for:
The text was updated successfully, but these errors were encountered: