Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting to analysis HDF5 should use user-labeled instance instead of predicted instance when available #637

Closed
talmo opened this issue Jan 28, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@talmo
Copy link
Collaborator

talmo commented Jan 28, 2022

Currently, proofreading is primarily used to correct track identities to fix swaps and etc.

To adjust one or more landmarks, you have to double click on the prediction to create a user instance from it with nodes that are movable.

The problem is that both the original predicted instance and the new (corrected) user instance are both still stored in the labels. This could result in the original predicted instance being used instead of the new user instance when exporting to an analysis HDF5 file.

Thanks @olinesn for raising this issue!


Solutions:

  1. We should explicitly check for linked predicted <-> user instances by inspecting the Instance.from_predicted attribute.
  2. We could just write out all the predicted instances to the appropriate tracks and then the user instances, overwriting any predicted instances in the corresponding track channels of the exported tracks array.

The first option is more general and would work even when the Instance.track attribute isn't set (e.g., for single instance videos).

@talmo talmo added the enhancement New feature or request label Jan 28, 2022
@olinesn
Copy link

olinesn commented Feb 5, 2022

Thanks for documenting!

@talmo talmo changed the title Make it easier to correct single landmarks in proofreading predictions Exporting to analysis HDF5 should use user-labeled instance instead of predicted instance when available May 12, 2022
@roomrys roomrys self-assigned this Jun 1, 2022
@roomrys roomrys added the fixed in future release Fix or feature is merged into develop and will be available in future release. label Jun 13, 2022
@roomrys
Copy link
Collaborator

roomrys commented Jun 29, 2022

Hi @olinesn ,

The new release of SLEAP v1.2.4 is now available for installation and includes this fix.

Thanks,
Liezl

@roomrys roomrys closed this as completed Jun 29, 2022
@roomrys roomrys removed the fixed in future release Fix or feature is merged into develop and will be available in future release. label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants