You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As refered above, this call to _initiate_upload() in _upload_resumable() does not pass timeout argument which may be set on calling upload() (in same class, Storage). Result in all function called in _initiate_upload() respect to its default timeout, which is DEFAULT_TIMEOUT in _initiate_upload().
I'm not sure if it is intended or not; if so, I would recommend to add some explanation; if not, I would glad to open a PR for this.
Thanks for you guys creating this useful stuff.
The text was updated successfully, but these errors were encountered:
Thanks for the report! Yeah, this was originally intended (though in retrospect might be a bad idea!) as I felt as a user setting a "timeout value for an upload" was most reasonably likely to refer to a timeout for the upload itself rather than for a specific part of the handshake. That said, I'd certainly be open to changing this if folks think it's unclear!
Some options to consider:
leave as is, document this better
use the current timeout value for both the initiate and the "do" steps
add a new initiate_timeout param to plumb into the initiate step
I think personally I would lean to the last of those options, as I'd rather keep things explicit. Thoughts?
gcloud-aio/storage/gcloud/aio/storage/storage.py
Line 558 in 57c6a92
As refered above, this call to
_initiate_upload()
in_upload_resumable()
does not passtimeout
argument which may be set on callingupload()
(in same class,Storage
). Result in all function called in_initiate_upload()
respect to its default timeout, which isDEFAULT_TIMEOUT
in_initiate_upload()
.I'm not sure if it is intended or not; if so, I would recommend to add some explanation; if not, I would glad to open a PR for this.
Thanks for you guys creating this useful stuff.
The text was updated successfully, but these errors were encountered: