Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cellnote not working with ggheatmap #278

Open
askhari139 opened this issue Sep 13, 2022 · 4 comments
Open

cellnote not working with ggheatmap #278

askhari139 opened this issue Sep 13, 2022 · 4 comments
Labels
bug

Comments

@askhari139
Copy link

Describe the bug

Annotation using the cellnote option is not working. Below are the minimal examples that cause me the error. Am I missing something?

To Reproduce

ggheatmap(mtcars, draw_cellnote = T, cellnote_color = "white", cellnote_size = 20)
ggheatmap(mtcars, cellnote = mtcars)
@askhari139 askhari139 added the bug label Sep 13, 2022
@alanocallaghan
Copy link
Collaborator

Nah this isn't currently supported because cellnote is added as a plotly layer

@askhari139
Copy link
Author

I see. Is there a way to support geom_text in the heatmap layers?

@alanocallaghan
Copy link
Collaborator

Not easily, but if you fancy making a pull request I can provide some guidance

@alanocallaghan
Copy link
Collaborator

Check out the cellnote branch if you like, but the functionality is worse on almost all counts than the existing version so I'm unlikely to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alanocallaghan @askhari139