Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

Consider using streaming responses for rpc requests with potentially large output #200

Open
bigspider opened this issue Aug 18, 2020 · 0 comments
Labels

Comments

@bigspider
Copy link
Collaborator

GRPC allows streaming responses; perhaps that would be more appropriate for requests like get_all_appointments that might have a very large output.

We should also make sure that the read lock is released quickly even if the response is large; if needed we could make a copy of the returned data and returning that copy after releasing the lock (since those requests come from the rpc − therefore from the cli − DoS attacks are not a concern).

@bigspider bigspider added the grpc label Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant