Skip to content

Commit

Permalink
Fix bind DOCKER_OPTS option (vdaas#2718)
Browse files Browse the repository at this point in the history
* 🐛 Fix bind DOCKER_OPTS option

Signed-off-by: vankichi <[email protected]>

* Fix

---------

Signed-off-by: vankichi <[email protected]>
  • Loading branch information
vankichi authored and takuyaymd committed Dec 2, 2024
1 parent 0725574 commit 6d3c6cf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion .github/workflows/dockers-example-client-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,4 @@ jobs:
uses: ./.github/workflows/_docker-image.yaml
with:
target: example-client
platforms: linux/amd64,linux/arm64
secrets: inherit
6 changes: 3 additions & 3 deletions Makefile.d/docker.mk
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ docker/name/loadtest:
## build loadtest image
docker/build/loadtest:
@make DOCKERFILE="$(ROOTDIR)/dockers/tools/cli/loadtest/Dockerfile" \
DOCKER_OPTS="--build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF5_VERSION=$(HDF5_VERSION)" \
DOCKER_OPTS="$${DOCKER_OPTS:+$${DOCKER_OPTS}} --build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF4_VERSION=$(HDF5_VERSION)" \
IMAGE=$(LOADTEST_IMAGE) \
docker/build/image

Expand Down Expand Up @@ -372,7 +372,7 @@ docker/name/benchmark-job:
docker/build/benchmark-job:
@make DOCKERFILE="$(ROOTDIR)/dockers/tools/benchmark/job/Dockerfile" \
IMAGE=$(BENCHMARK_JOB_IMAGE) \
DOCKER_OPTS="--build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF5_VERSION=$(HDF5_VERSION)" \
DOCKER_OPTS="$${DOCKER_OPTS:+$${DOCKER_OPTS}} --build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF4_VERSION=$(HDF5_VERSION)" \
docker/build/image

.PHONY: docker/name/benchmark-operator
Expand All @@ -395,5 +395,5 @@ docker/name/example-client:
docker/build/example-client:
@make DOCKERFILE="$(ROOTDIR)/dockers/example/client/Dockerfile" \
IMAGE=$(EXAMPLE_CLIENT_IMAGE) \
DOCKER_OPTS="--build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF5_VERSION=$(HDF5_VERSION)" \
DOCKER_OPTS="$${DOCKER_OPTS:+$${DOCKER_OPTS}} --build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF4_VERSION=$(HDF5_VERSION)" \
docker/build/image

0 comments on commit 6d3c6cf

Please sign in to comment.