Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMBO performance #183

Open
mamengyiyi opened this issue May 6, 2022 · 4 comments
Open

COMBO performance #183

mamengyiyi opened this issue May 6, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@mamengyiyi
Copy link

Hi, I run COMBO on v2 version d4rl MuJoCo Gym datasets and found that the performances are surprisingly poor. For example, the normalized score after training 1M step of COMBO on walker2d-medium-expert-v2 is -0.18, on halfcheetah-medium-replay-v2 is 35.98 (The results fluctuated between 30-60 in the last few steps). Did I do something wrong?

@mamengyiyi mamengyiyi added the bug Something isn't working label May 6, 2022
@tangbotony
Copy link

same as you

@takuseno
Copy link
Owner

We confirmed that three is an issue about rollout termination. For now, COMBO is still an experimental feature.
#101 (comment)

@typoverflow
Copy link

typoverflow commented Jan 7, 2023

Hello,
any updates about this issue? With some experiments using the code from d3rlpy and https://agit.ai/Polixir/OfflineRL/src/branch/master/offlinerl/algo/modelbase/combo.py, I found that for both MOPO and COMBO, there are gaps between the actual performances and what was reported in the original paper.

I'm quite skeptical about the reproducibility of some model-based offline RL algorithms (see tianheyu927/mopo#5). The source code of COMBO is not even released (as far as I know).

@takuseno
Copy link
Owner

takuseno commented Jan 9, 2023

Sorry for the inconvenience. Currently, COMBO support is a low priority because I'm working on Transformer architecture support in nightly branch. I still believe that environmental termination is the key to fix this issue. Once I sort it out, hope I can revisit this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants