Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially remove support for Java 1.6 #5

Open
jvanzyl opened this issue Apr 28, 2015 · 4 comments
Open

Officially remove support for Java 1.6 #5

jvanzyl opened this issue Apr 28, 2015 · 4 comments

Comments

@jvanzyl
Copy link
Contributor

jvanzyl commented Apr 28, 2015

There are some references to Java 1.6 and this project is only going to support Java 1.7+ so the documentation needs to be corrected.

@cdman
Copy link
Contributor

cdman commented May 6, 2015

I submitted a small PR (#8) which makes the project 1.6 compatible. Can we have this for at least one release - pretty please? :-)

It also makes it so JUnit is a compile time dependency so that users of the library aren't forced to use the specific version of JUnit used by cpsuite (by virtue of it being a transitive dependency) or having to do manual exclusions.

FYI, the parent pom seems to have a newer version than it's being used (14 vs. 17 - see http://search.maven.org/#search|ga|1|a%3A%22takari%22) and there is a newer maven compiler plugin (the parent pom v14 specifies 2.3.2 while v17 specifies 3.2 and the latest is 3.3 - see http://search.maven.org/#search|ga|1|maven-compiler-plugin). Perhaps we can upgrade these?

Also, any reason for using packaging "takari-jar" and the "takari-lifecycle-plugin"? I had to comment these out / revert back to plain jar packaging, otherwise I couldn't import the project into Eclipse / couldn't build it on the command line.

On the command line I get:

[ERROR] Failed to execute goal io.takari.maven.plugins:takari-lifecycle-plugin:1.10.1:compile (default-compile) on project takari-cpsuite: Execution default-compile of goal io.takari.maven.plugins:takari-lifecycle-plugin:1.10.1:compile failed: Unexpected input change /home/balazsa/ingenuity/takari-cpsuite/src/main/java/org/junit/extensions/cpsuite/ClasspathClassesFinder.java -> [Help 1]

I'm using Ubuntu 15.04 with OpenJDK 1.8.0_45-internal and Maven 3.3.3:

Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-22T14:57:37+03:00)
Maven home: ...
Java version: 1.8.0_45-internal, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.19.0-15-generic", arch: "amd64", family: "unix"

@jvanzyl
Copy link
Contributor Author

jvanzyl commented May 6, 2015

Sure, we can do this release for 1.6. No problem.

@jvanzyl
Copy link
Contributor Author

jvanzyl commented May 6, 2015

I'll make some instructions on why we use takari-jar, as I wish those to remain. They should work correctly in Eclipse. Did M2Eclipse not find the right connector for you?

@frab3
Copy link

frab3 commented Jun 23, 2015

Will there be an upcoming release which fixes the 1.6 compatibility? Right now I cannot use the cpsuite plugin from maven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants