Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose of this repostory #77

Closed
furkanedu opened this issue May 19, 2016 · 5 comments
Closed

Purpose of this repostory #77

furkanedu opened this issue May 19, 2016 · 5 comments

Comments

@furkanedu
Copy link

Please give a clear explanation of the purpose of this repository, why it is created, what exactly it offers etc ? I wondered why this repo is used in react-redux-universal-hot-example and I have no idea since there is no explanation.

@taion
Copy link
Owner

taion commented May 19, 2016

It's in the README.

@taion taion closed this as completed May 19, 2016
@faceyspacey
Copy link

he's not alone. this repo needs a full-on example. it's too abstract for the uninitiated. my 2 cents.

@taion
Copy link
Owner

taion commented Apr 30, 2017

Well, what are you trying to do? In general, as noted, you should probably be using react-router-scroll or Found Scroll, instead of using this library directly.

@faceyspacey
Copy link

I see that now (though I don't see any reference to Found Scroll). ...The fork of react-router-scroll for the latest React Router that uses history.listen actually is the closest thing to a general example. It's what I begun using yesterday as the basis for the scroll restoration implementation I'm working on for:

https://github.com/faceyspacey/pure-redux-router

For people arriving at this repo before react-router-scroll (or before having used it), I think a simple example, even if just a few lines in the main readme, would go a long way. This is a pretty damn good repo in how general it is. There's no need for people to reinvent the wheel with something like this having solved all the annoying browser deficiencies.

...here's how I think it should look:

#118

@taion
Copy link
Owner

taion commented May 2, 2017

#119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants