Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update peer dependency #68

Closed
kopax opened this issue Mar 10, 2017 · 5 comments
Closed

update peer dependency #68

kopax opened this issue Mar 10, 2017 · 5 comments

Comments

@kopax
Copy link

kopax commented Mar 10, 2017

Will you please release a new version ?

- [email protected] node_modules/history
- [email protected] node_modules/react-router
npm WARN [email protected] requires a peer of history@^2.0.0 || ^3.0.0 but none was installed.
npm WARN [email protected] requires a peer of react-router@^2.3.0 || ^3.0.0 but none was installed.
[email protected] /workspace/git.domain.com/namespace/bo-logic
└─┬ [email protected] 
  └── [email protected]

I have tested it and it work great.
@taion
Copy link
Owner

taion commented Mar 10, 2017

You can see that the peer dep supports v3 for both React Router and history in the same error message you just copy-pasted...

@taion taion closed this as completed Mar 10, 2017
@kopax
Copy link
Author

kopax commented Mar 10, 2017

We are using V4

@taion
Copy link
Owner

taion commented Mar 10, 2017

this library is not compatible with RRv4

@tamitutor
Copy link

Will it be compatible?

@taion
Copy link
Owner

taion commented Mar 28, 2017

see #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tamitutor @kopax @taion