Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include the license file in the NPM package #1139

Closed
mitar opened this issue Feb 29, 2024 · 2 comments · Fixed by #1151
Closed

Please include the license file in the NPM package #1139

mitar opened this issue Feb 29, 2024 · 2 comments · Fixed by #1151
Assignees

Comments

@mitar
Copy link

mitar commented Feb 29, 2024

The package is MIT licensed, but the NPM package is missing a copy of the license. As such it is hard to satisfy MIT license conditions which require from me to include a copyright notice (which is otherwise found in the license file) as I am using the installed NPM package files and not the source code itself to search for the license file.

I think this should be as simple as adding LICENSE to the files list in package.json.

@mitar
Copy link
Author

mitar commented Mar 22, 2024

Thanks!

@reinink
Copy link
Member

reinink commented Mar 22, 2024

Hey, no problem, we normally include the license file with our published packages, so this must have just been an oversight. I've added it to all three packages and have published new releases 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants