From ec89e4c34a62ccd2c264b71911ffcad5d68d7965 Mon Sep 17 00:00:00 2001 From: Robin Malfait Date: Mon, 21 Mar 2022 16:58:03 +0100 Subject: [PATCH 1/3] stop propagation on Popover Button This is only done on buttons that are **not** inside the Popover Panel. --- packages/@headlessui-react/src/components/popover/popover.tsx | 2 ++ packages/@headlessui-vue/src/components/popover/popover.ts | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/@headlessui-react/src/components/popover/popover.tsx b/packages/@headlessui-react/src/components/popover/popover.tsx index 375cbd107b..67eb05dc11 100644 --- a/packages/@headlessui-react/src/components/popover/popover.tsx +++ b/packages/@headlessui-react/src/components/popover/popover.tsx @@ -461,6 +461,8 @@ let Button = forwardRefWithAs(function Button Date: Mon, 21 Mar 2022 16:59:57 +0100 Subject: [PATCH 2/3] update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9a7430b24f..3b87b49236 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Add `multi` value support for Listbox & Combobox ([#1243](https://github.com/tailwindlabs/headlessui/pull/1243)) - Improve Combobox Input value ([#1248](https://github.com/tailwindlabs/headlessui/pull/1248)) - Fix Tree-shaking support ([#1247](https://github.com/tailwindlabs/headlessui/pull/1247)) +- Stop propagation on the Popover Button ([#1263](https://github.com/tailwindlabs/headlessui/pull/1263)) ### Added @@ -60,6 +61,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Add `multi` value support for Listbox & Combobox ([#1243](https://github.com/tailwindlabs/headlessui/pull/1243)) - Improve Combobox Input value ([#1248](https://github.com/tailwindlabs/headlessui/pull/1248)) - Fix Tree-shaking support ([#1247](https://github.com/tailwindlabs/headlessui/pull/1247)) +- Stop propagation on the Popover Button ([#1263](https://github.com/tailwindlabs/headlessui/pull/1263)) ### Added From fbba9c71de8acf0abe4135dc276c87da61d7232d Mon Sep 17 00:00:00 2001 From: Robin Malfait Date: Mon, 21 Mar 2022 17:03:52 +0100 Subject: [PATCH 3/3] trigger CI