Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<TransitionChild> does not work when unmount is set to false #3375

Open
spacecat opened this issue Jul 9, 2024 · 2 comments
Open

<TransitionChild> does not work when unmount is set to false #3375

spacecat opened this issue Jul 9, 2024 · 2 comments
Assignees

Comments

@spacecat
Copy link

spacecat commented Jul 9, 2024

I think this one is related to #3348

Repro:

  1. Go to https://tailwindui.com/components/application-ui/application-shells/sidebar
  2. Take the react code from the first example: https://tailwindui.com/components/application-ui/application-shells/sidebar#component-73d9b2c2e2af9184f305f06649710086
  3. Add unmount={false} to the <Dialog> component )
  4. Now <TransitionChild> is broken - The Close (X) button at the top right dissapears on mobile!

I'm using "@headlessui/react": "^0.0.0-insiders.a36380f",

@RobinMalfait RobinMalfait self-assigned this Jul 10, 2024
@RobinMalfait
Copy link
Member

Hey!

Small update in the meantime. You can add unmount={false} to the <TransitionChild /> to work around this for now.

@spacecat
Copy link
Author

Thanks @RobinMalfait, it's working!

When do you think there will be a new version of headless UI? :) The latest version is 2.1.2 I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants