Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition enterFrom classes not working with Menu #2914

Closed
zce opened this issue Jan 4, 2024 · 6 comments · Fixed by #3074
Closed

Transition enterFrom classes not working with Menu #2914

zce opened this issue Jan 4, 2024 · 6 comments · Fixed by #3074

Comments

@zce
Copy link

zce commented Jan 4, 2024

What package within Headless UI are you using?

@headlessui/react

What version of that package are you using?

v2.0.0-alpha.4

What browser are you using?

Edge

Reproduction URL

https://stackblitz.com/edit/stackblitz-starters-a9u657?file=app%2Fmenu-demo.tsx

Describe your issue

rec.mp4
@ilkkakuivanen
Copy link

I have similar issue with Dialog.

  • The issue started with 1.7.18.
  • Current fix is to roll back to 1.7.17.
  • One noticeable issue seems to be not all steps are correctly iterated. At least the "enterTo" class is not persistent as it should when the dialog is open.
  • The issue seems to occur with any use of <Transition/>

@RaenonX
Copy link

RaenonX commented Jan 14, 2024

I have similar issue with Dialog.

  • The issue started with 1.7.18.
  • Current fix is to roll back to 1.7.17.
  • One noticeable issue seems to be not all steps are correctly iterated. At least the "enterTo" class is not persistent as it should when the dialog is open.
  • The issue seems to occur with any use of <Transition/>

I think this bug might be introduced by #2722. Agree that enterTo should persist what it has, as making what was enterTo to be entered will be a different behavior here.

@sahibjotsaggu
Copy link

sahibjotsaggu commented Feb 5, 2024

@ilkkakuivanen I've created a codesandbox here with version 1.7.17 but the transition still isn't working. Any ideas?

@areriklq
Copy link

I have pinpointed a bug relating to enterTo to being introduced in 1.7.18, I upgraded version-by-version to confirm this.

The following transitions worked in 1.7.17 but in 1.7.18 the classes for enterTo are never appended to the element.
image

As mentioned before this is most likely due to #2722 . Could @RobinMalfait confirm?

@RobinMalfait
Copy link
Member

Hey!

This should be fixed by #3074, and will be available in the next release.

You can already try it using:

  • npm install @headlessui/react@insiders.

@RaenonX
Copy link

RaenonX commented Apr 20, 2024

Hi @RobinMalfait
May I know which version include this fix?
Despite the timeline (your comment 2 weeks ago vs v1.7.19 release 5 days ago), this fix seems only included insiders version, not the formal release version.

See https://github.com/RaenonX/test-transition/commits/main/ where after https://github.com/RaenonX/test-transition/commit/a915a75be566c2c9bdfac02970c772cc14451489, the issue still persists, and only gets fixed by https://github.com/RaenonX/test-transition/commit/45f73ad377f546358a2a03aa83b96d8a05ce8d8d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants