Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on a Combobox with portal inside of a Popover with portal closes the Popover #2481

Closed
zgagnon opened this issue May 5, 2023 · 2 comments · Fixed by #2492
Closed
Assignees

Comments

@zgagnon
Copy link

zgagnon commented May 5, 2023

What package within Headless UI are you using?

import { Combobox , Popover, Portal} from "@headlessui/react"

What version of that package are you using?

@headlessui/react 1.7.4

What browser are you using?

Chrome

Reproduction URL

Minimal reproduction in index.js of this repo: https://github.com/zgagnon/headless-repro

Describe your issue

When a combobox with float and portal is nested inside a popover with float, clicking the combobox options closes the popover.

Reproduction in repo:

  1. Click the open button
  2. Click in to the combobox input
  3. Trigger the combobox by typing t
  4. Click on any of the names
  5. The popover closes

Expected:
The popover does not close

@RobinMalfait
Copy link
Member

Hey, thank you for this bug report! 🙏

This should be fixed by #2492, and will be available in the next release.

You can already try it using:

  • npm install @headlessui/react@insiders.
  • npm install @headlessui/vue@insiders.

@zgagnon
Copy link
Author

zgagnon commented May 19, 2023

Thank you for the swift action! We ran into this recently and it was a real stumbling block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants