-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controlled Comobox shows only one option after selecting #1997
Comments
It seems this was introduced in #1916 This breaks the Combobox completely for us. We're using a debounced fetch to populate the Combobox. Selecting an item results in an extra fetch with the result of the Not only is this extra fetch unwanted (and unnecessary) but the selected value is also lost and using the |
There are problems with headlessui/vue as well since around version 1.7.4. We're using a function for |
Hey! Thank you for your bug report! This should be fixed by #2042, and will be available in the next release. You can already try it using:
I've also updated your CodeSandbox URL with the latest insiders version: https://codesandbox.io/s/headless-ui-comobox-issue-forked-3iiimq?file=/package.json |
@RobinMalfait thank you 🙏 |
Thanks @RobinMalfait the insiders version works like before 👍 looking forward to the release :) |
What package within Headless UI are you using?
@headlessui/react
What version of that package are you using?
v1.7.4
Reproduction URL
https://codesandbox.io/s/headless-ui-comobox-issue-gulbsz?file=/src/index.js
Describe your issue
Since version 1.7.4 the Comobox component shows only the option already selected from the Combobox Button. You can see the difference by switching to version 1.7.3.
I'd expect that as in the previous version, all available options will be shown to the user.
The text was updated successfully, but these errors were encountered: