Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤯 Popover.Button can not stop propagation #1260

Closed
chioio opened this issue Mar 19, 2022 · 3 comments · Fixed by #1263
Closed

🤯 Popover.Button can not stop propagation #1260

chioio opened this issue Mar 19, 2022 · 3 comments · Fixed by #1263

Comments

@chioio
Copy link

chioio commented Mar 19, 2022

What package within Headless UI are you using?

@headlessui/react

What version of that package are you using?

v1.5.0

What browser are you using?

Chrome

Describe your issue

When I define a click event on parent container, the inner popover button click not stop propagation.

@RobinMalfait
Copy link
Member

Hey! Thank you for your bug report!
Much appreciated! 🙏

This should be fixed by #1263, and will be available in the next release.

You can already try it using:

  • npm install @headlessui/react@insiders or yarn add @headlessui/react@insiders.
  • npm install @headlessui/vue@insiders or yarn add @headlessui/vue@insiders.

@toantran201
Copy link

Hi @RobinMalfait , I think the same problem with Listbox.Button.

@RobinMalfait
Copy link
Member

@toantran201 please open a new issue with a reproduction repo / CodeSandbox attached to it.

@tailwindlabs tailwindlabs locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants