Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(grpc): proto files are not found #1686

Closed
tusharmath opened this issue Apr 10, 2024 · 2 comments
Closed

bug(grpc): proto files are not found #1686

tusharmath opened this issue Apr 10, 2024 · 2 comments
Labels
type: bug Something isn't working.

Comments

@tusharmath
Copy link
Contributor

While running from the CLI to generate a tailcall configuration the paths of the proto dependencies aren't correctly resolved, often resulting in errors as files aren't found.

Technical Requirements
Current, implementation is hand written, we should use leverage Protox's file resolution capabilities to do this.

https://docs.rs/protox/0.6.0/protox/file/index.html

@tusharmath tusharmath added the type: bug Something isn't working. label Apr 10, 2024
@ssddOnTop
Copy link
Member

originally we were using protox crate but we dropped it (in #1041) for WASM support because it uses std::fs.

@amitksingh1490
Copy link
Collaborator

Fixed in #1705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants