Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): ios dropdown a11y and horizontal padding #425

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

dionysuzx
Copy link
Collaborator

@dionysuzx dionysuzx commented Dec 13, 2022

summary

  • this improves a11y for ios, where dropdown wasn't working.
  • in another PR i can reduce the image size of the logo and make the container more sensible, but this seems like an easy improvement.
  • switches swap icon for left-right icon (from heroicons)

screenshot

image

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #425 (10fada1) into main (d42b953) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   65.02%   65.18%   +0.15%     
==========================================
  Files          96       96              
  Lines        2605     2605              
  Branches      313      313              
==========================================
+ Hits         1694     1698       +4     
+ Misses        844      840       -4     
  Partials       67       67              
Flag Coverage Δ *Carryforward flag
bridge-ui 100.00% <ø> (ø)
protocol 58.54% <ø> (+0.28%) ⬆️ Carriedforward from 37e9bb6
relayer 68.34% <ø> (ø) Carriedforward from 37e9bb6
ui 100.00% <ø> (ø) Carriedforward from 37e9bb6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ges/protocol/contracts/libs/LibAnchorSignature.sol 89.47% <0.00%> (-10.53%) ⬇️
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dionysuzx dionysuzx merged commit b8fbdea into main Dec 14, 2022
@dionysuzx dionysuzx deleted the feat/bridge-ios-dropdown branch December 14, 2022 01:17
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants