Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge): minor responsiveness fixes #407

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Conversation

shadab-taiko
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #407 (8cd79d4) into main (6d1abf7) will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   65.18%   65.53%   +0.35%     
==========================================
  Files          96       96              
  Lines        2605     2594      -11     
  Branches      313      310       -3     
==========================================
+ Hits         1698     1700       +2     
+ Misses        839      827      -12     
+ Partials       68       67       -1     
Flag Coverage Δ *Carryforward flag
bridge-ui 100.00% <ø> (ø)
protocol 59.14% <ø> (+0.60%) ⬆️ Carriedforward from 184c88d
relayer 68.34% <ø> (ø) Carriedforward from 184c88d
ui 100.00% <ø> (ø) Carriedforward from 184c88d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/libs/LibTxDecoder.sol 84.37% <0.00%> (-0.17%) ⬇️
packages/protocol/contracts/L1/LibData.sol 21.42% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Utils.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Proving.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Proposing.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Verifying.sol 19.51% <0.00%> (+0.90%) ⬆️
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 91.56% <0.00%> (+1.20%) ⬆️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik changed the title fix: minor responsiveness fixes fix(bridge): minor responsiveness fixes Dec 9, 2022
RogerLamTd
RogerLamTd previously approved these changes Dec 9, 2022
packages/bridge-ui/src/components/Navbar.svelte Outdated Show resolved Hide resolved
packages/bridge-ui/src/components/Navbar.svelte Outdated Show resolved Hide resolved
@shadab-taiko shadab-taiko merged commit 0d617c5 into main Dec 9, 2022
@shadab-taiko shadab-taiko deleted the responsiveness-fixes branch December 9, 2022 20:22
cyberhorsey added a commit that referenced this pull request Dec 9, 2022
* fix: minor responsiveness fixes

* fix(bridge): remove console logs

Co-authored-by: Roger <[email protected]>
Co-authored-by: jeff <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants