Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix BlockVerified event #381

Merged
merged 2 commits into from
Dec 7, 2022
Merged

fix(protocol): fix BlockVerified event #381

merged 2 commits into from
Dec 7, 2022

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Dec 7, 2022

Fix an issue which will always make the blockHash field in BlockVerified events be 0x0.

@davidtaikocha davidtaikocha marked this pull request as ready for review December 7, 2022 09:07
@davidtaikocha davidtaikocha requested a review from dantaik December 7, 2022 09:07
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #381 (bc13cc1) into main (608e3e3) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #381   +/-   ##
=======================================
  Coverage   64.08%   64.08%           
=======================================
  Files          89       89           
  Lines        2492     2492           
  Branches      292      292           
=======================================
  Hits         1597     1597           
  Misses        828      828           
  Partials       67       67           
Flag Coverage Δ *Carryforward flag
bridge-ui 100.00% <ø> (ø) Carriedforward from 608e3e3
protocol 59.00% <0.00%> (ø)
relayer 68.34% <ø> (ø) Carriedforward from 608e3e3
ui 100.00% <ø> (ø) Carriedforward from 608e3e3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/v1/V1Verifying.sol 19.51% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik enabled auto-merge (squash) December 7, 2022 09:53
@vercel
Copy link

vercel bot commented Dec 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bridge-ui ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 10:06AM (UTC)

@dantaik dantaik merged commit fe479c8 into main Dec 7, 2022
@dantaik dantaik deleted the fix-BlockVerified branch December 7, 2022 15:14
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants