Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): whitelist provers & temporarily disable coverage check #296

Merged
merged 8 commits into from
Nov 21, 2022

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Nov 19, 2022

Currently some PRs' CI checks failed since codecov will automatically add two actions to measure the coverage diff against the base of that PR, e.g: #287

image

Since our code is often written and tested by different person and PR, we need to disable these codecov actions?

Currently one of our codecov badges is always unknown:
image

This PR also tries to fix this.

@davidtaikocha davidtaikocha self-assigned this Nov 19, 2022
@davidtaikocha davidtaikocha changed the title chore(ci): disable checking coverage against the base of the PR chore(ci): disable checking coverage diff against the base of the PR Nov 19, 2022
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #296 (1e2af2f) into main (54a266d) will decrease coverage by 5.26%.
The diff coverage is 5.00%.

@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   68.87%   63.60%   -5.27%     
==========================================
  Files          25       79      +54     
  Lines        1073     2377    +1304     
  Branches        0      269     +269     
==========================================
+ Hits          739     1512     +773     
- Misses        263      796     +533     
+ Partials       71       69       -2     
Flag Coverage Δ *Carryforward flag
protocol 59.82% <5.00%> (?)
relayer 68.57% <ø> (-0.30%) ⬇️ Carriedforward from 54a266d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/LibData.sol 21.42% <ø> (ø)
packages/protocol/contracts/L1/TaikoL1.sol 19.51% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Proving.sol 0.00% <0.00%> (ø)
...col/contracts/test/bridge/libs/TestBadReceiver.sol 40.00% <ø> (ø)
...ol/contracts/test/thirdparty/TestMessageSender.sol 100.00% <ø> (ø)
.../contracts/test/bridge/libs/TestLibBridgeRetry.sol 100.00% <100.00%> (ø)
packages/relayer/types.go
packages/relayer/event.go
...contracts/test/bridge/libs/TestLibBridgeSignal.sol 0.00% <0.00%> (ø)
... and 54 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha marked this pull request as draft November 19, 2022 07:56
@davidtaikocha davidtaikocha changed the title chore(ci): disable checking coverage diff against the base of the PR chore(ci): disable checking coverage diff against the base of the PR && and fix README codecov badges Nov 19, 2022
@davidtaikocha davidtaikocha changed the title chore(ci): disable checking coverage diff against the base of the PR && and fix README codecov badges chore(ci): disable checking coverage diff against the base of the PR && fix README codecov badges Nov 19, 2022
@davidtaikocha davidtaikocha marked this pull request as ready for review November 19, 2022 08:04
dantaik
dantaik previously approved these changes Nov 19, 2022
dantaik
dantaik previously approved these changes Nov 19, 2022
@dantaik dantaik changed the title chore(ci): disable checking coverage diff against the base of the PR && fix README codecov badges feat(protocol): whitelist provers & temporarily disable coverage check Nov 20, 2022
@dantaik dantaik changed the title feat(protocol): whitelist provers & temporarily disable coverage check feat(protocol): 1 > whitelist provers & temporarily disable coverage check Nov 20, 2022
@dantaik dantaik changed the title feat(protocol): 1 > whitelist provers & temporarily disable coverage check feat(protocol): step 1: whitelist provers & temporarily disable coverage check Nov 20, 2022
@dantaik dantaik changed the title feat(protocol): step 1: whitelist provers & temporarily disable coverage check feat(protocol): step 1 - whitelist provers & temporarily disable coverage check Nov 20, 2022
@dantaik dantaik changed the title feat(protocol): step 1 - whitelist provers & temporarily disable coverage check feat(protocol): whitelist provers & temporarily disable coverage check Nov 21, 2022
@dantaik dantaik merged commit 06ceee2 into main Nov 21, 2022
@dantaik dantaik deleted the disable-codecov-project-patch branch November 21, 2022 04:53
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants