-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): whitelist provers & temporarily disable coverage check #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaikocha
changed the title
chore(ci): disable checking coverage against the base of the PR
chore(ci): disable checking coverage diff against the base of the PR
Nov 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #296 +/- ##
==========================================
- Coverage 68.87% 63.60% -5.27%
==========================================
Files 25 79 +54
Lines 1073 2377 +1304
Branches 0 269 +269
==========================================
+ Hits 739 1512 +773
- Misses 263 796 +533
+ Partials 71 69 -2
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
davidtaikocha
changed the title
chore(ci): disable checking coverage diff against the base of the PR
chore(ci): disable checking coverage diff against the base of the PR && and fix README codecov badges
Nov 19, 2022
davidtaikocha
changed the title
chore(ci): disable checking coverage diff against the base of the PR && and fix README codecov badges
chore(ci): disable checking coverage diff against the base of the PR && fix README codecov badges
Nov 19, 2022
dantaik
previously approved these changes
Nov 19, 2022
dantaik
previously approved these changes
Nov 19, 2022
dantaik
approved these changes
Nov 20, 2022
dantaik
changed the title
chore(ci): disable checking coverage diff against the base of the PR && fix README codecov badges
feat(protocol): whitelist provers & temporarily disable coverage check
Nov 20, 2022
dantaik
changed the title
feat(protocol): whitelist provers & temporarily disable coverage check
feat(protocol): 1 > whitelist provers & temporarily disable coverage check
Nov 20, 2022
dantaik
changed the title
feat(protocol): 1 > whitelist provers & temporarily disable coverage check
feat(protocol): step 1: whitelist provers & temporarily disable coverage check
Nov 20, 2022
dantaik
changed the title
feat(protocol): step 1: whitelist provers & temporarily disable coverage check
feat(protocol): step 1 - whitelist provers & temporarily disable coverage check
Nov 20, 2022
dionysuzx
approved these changes
Nov 21, 2022
dantaik
changed the title
feat(protocol): step 1 - whitelist provers & temporarily disable coverage check
feat(protocol): whitelist provers & temporarily disable coverage check
Nov 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some PRs' CI checks failed since codecov will automatically add two actions to measure the coverage diff against the base of that PR, e.g: #287
Since our code is often written and tested by different person and PR, we need to disable these codecov actions?
Currently one of our codecov badges is always unknown:
This PR also tries to fix this.