-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(relayer): HTTP api for exposing events table for bridge UI #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
cyberhorsey
changed the title
fear(relayer): WIP: on HTTP api for exposing events table for bridge UI
feat(relayer): DRAFT: on HTTP api for exposing events table for bridge UI
Nov 14, 2022
cyberhorsey
commented
Nov 23, 2022
Codecov Report
@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 62.91% 63.10% +0.18%
==========================================
Files 82 83 +1
Lines 2416 2450 +34
Branches 281 281
==========================================
+ Hits 1520 1546 +26
- Misses 828 832 +4
- Partials 68 72 +4
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cyberhorsey
changed the title
feat(relayer): DRAFT: on HTTP api for exposing events table for bridge UI
feat(relayer): HTTP api for exposing events table for bridge UI
Nov 23, 2022
dantaik
approved these changes
Nov 23, 2022
davidtaikocha
approved these changes
Nov 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #245
WIP. It is probably better to expose a websockets endpoint rather than have the client poll. Maybe HTTP for the Events themselves and WSS for status updates.