Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge): use metamask wagmi connector #2080

Merged
merged 4 commits into from
Dec 30, 2022
Merged

Conversation

shadab-taiko
Copy link
Contributor

Fixes issues with multiple wallets of same name showing up or connect wallet flow not highlighting if a wallet is not installed.

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #2080 (926fa71) into main (6c080cb) will not change coverage.
The diff coverage is n/a.

❗ Current head 926fa71 differs from pull request most recent head 3204be1. Consider uploading reports for the commit 3204be1 to get more accurate results

@@           Coverage Diff           @@
##             main    #2080   +/-   ##
=======================================
  Coverage   66.79%   66.79%           
=======================================
  Files         106      106           
  Lines        2843     2843           
  Branches      354      354           
=======================================
  Hits         1899     1899           
  Misses        868      868           
  Partials       76       76           
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø)
protocol 58.88% <ø> (ø) Carriedforward from db7a5bd
relayer 69.10% <ø> (ø) Carriedforward from db7a5bd
ui 100.00% <ø> (ø) Carriedforward from db7a5bd

*This pull request uses carry forward flags. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

davidtaikocha
davidtaikocha previously approved these changes Dec 29, 2022
@vercel
Copy link

vercel bot commented Dec 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bridge-ui 🔄 Building (Inspect) Dec 30, 2022 at 2:39PM (UTC)
website 🔄 Building (Inspect) Dec 30, 2022 at 2:39PM (UTC)

dionysuzx
dionysuzx previously approved these changes Dec 29, 2022
dantaik
dantaik previously approved these changes Dec 29, 2022
@dantaik dantaik dismissed stale reviews from dionysuzx, davidtaikocha, and themself via 926fa71 December 29, 2022 16:20
@shadab-taiko shadab-taiko merged commit 0d74845 into main Dec 30, 2022
@shadab-taiko shadab-taiko deleted the wallet-selector-fix branch December 30, 2022 14:41
dantaik added a commit that referenced this pull request Jan 3, 2023
* fix(bridge): use metamask wagmi connector

* Update packages/bridge-ui/src/components/buttons/Connect.svelte

Co-authored-by: dave | d1onys1us <[email protected]>

Co-authored-by: dave | d1onys1us <[email protected]>
Co-authored-by: Daniel Wang <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants