Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): allow any ERC20 tokens or Ether to be used as bonds #18380

Merged
merged 10 commits into from
Nov 4, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Nov 3, 2024

@davidtaikocha if we adopt this change, we will need to register this name:

if (_name == LibStrings.B_BOND_TOKEN) {
  return (true, 0x10dea67478c5F8C5E2D90e5E9B26dBe60c54d800);
}

@dantaik dantaik marked this pull request as ready for review November 3, 2024 07:00
Copy link

openzeppelin-code bot commented Nov 3, 2024

feat(protocol): allow any ERC20 tokens or Ether to be used as bonds

Generated at commit: 5ae9679aad11ed18b6734ee2e89e99ffbd2fc455

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
7
42
55
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 1920521 Nov 4, 2024
5 checks passed
@dantaik dantaik deleted the decouple_bond_tokens branch November 4, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants