-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(relayer): profitability changes #18124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberhorsey
changed the title
fix(relayer): no need to multiply by 1.05 anymore
fix(relayer): profitability changes
Sep 17, 2024
davidtaikocha
approved these changes
Sep 17, 2024
RogerLamTd
approved these changes
Sep 17, 2024
…o into relayer_profitability
…o into relayer_profitability
RogerLamTd
approved these changes
Sep 17, 2024
dantaik
pushed a commit
that referenced
this pull request
Sep 18, 2024
Co-authored-by: Karim <[email protected]>
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used to have to multiply by
1.05
for padding, no longer necessary with previous bridge fee changes. Legacy code, now removed.As well, the optimism txmgr defines it's fee calculation as:
So we should use
baseFee * 2
, notbaseFee
,when determining profitability.