Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): add batch transfer and burn for BridgedERC721 #17058

Merged
merged 32 commits into from
May 9, 2024
Merged

refactor(protocol): add batch transfer and burn for BridgedERC721 #17058

merged 32 commits into from
May 9, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented May 9, 2024

This will save gas

@dantaik dantaik marked this pull request as ready for review May 9, 2024 03:26
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented May 9, 2024 •
edited
Loading

refactor(protocol): add batch transfer and burn for BridgedERC721

Generated at commit: 069081841995fd93c1a4f8fd11be2439b6d8c573

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
6
41
51
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the title refactor(protocol): add batch mint and burn function for bridged ERC721 tokens refactor(protocol): minimize vault-to-bridged-token contract calls May 9, 2024
dantaik added 6 commits May 9, 2024 12:18
@dantaik
Revert "more"
df8aaf7 
This reverts commit a0d4b61.
@dantaik
Revert "Merge branch 'batch_erc721' of ssh://github.com/taikoxyz/taik…
10d5691 
…o-mono into batch_erc721"

This reverts commit 0d7a806, reversing
changes made to abd90dd.
@dantaik
Revert "fix"
ad7c372 
This reverts commit abd90dd.
@dantaik
Revert "more"
5e6cf39 
This reverts commit 9e9e429.
@dantaik
Revert "more"
0dbcc0e 
This reverts commit c547326.
@dantaik
Merge branch 'batch_erc721' of ssh://github.com/taikoxyz/taiko-mono i…
2a04726 
…nto batch_erc721
@dantaik dantaik changed the title refactor(protocol): minimize vault-to-bridged-token contract calls refactor(protocol): add batch transfer and burn for BridgedERC721 May 9, 2024
Base automatically changed from vault_burn_design_fix to main May 9, 2024 06:31
@dantaik dantaik marked this pull request as draft May 9, 2024 07:37
dantaik added 2 commits May 9, 2024 15:39
@dantaik
more
5f85450
@dantaik
Revert "more"
0690818 
This reverts commit 5f85450.
@dantaik dantaik marked this pull request as ready for review May 9, 2024 07:41
@dantaik dantaik added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit cfc8fa8 May 9, 2024
4 checks passed
@dantaik dantaik deleted the batch_erc721 branch May 9, 2024 07:42
dantaik added a commit that referenced this pull request May 9, 2024
@dantaik
Revert "refactor(protocol): add batch transfer and burn for BridgedER…
4d851fc 
…C721 (#17058)"

This reverts commit cfc8fa8.
@openzeppelin-code openzeppelin-code bot mentioned this pull request May 9, 2024
Merged
dantaik added a commit that referenced this pull request May 9, 2024
@dantaik
Revert "refactor(protocol): add batch transfer and burn for BridgedER…
5c7e26b 
…C721 (#17058)"

This reverts commit cfc8fa8.
github-merge-queue bot pushed a commit that referenced this pull request May 9, 2024
@dantaik
fix(protocol): revert "add batch transfer and burn for BridgedERC721 (#…
84e3000 
…17058) (#17066)
This was referenced May 9, 2024
Merged
Closed
@taiko-kitty taiko-kitty mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@adaki2004 adaki2004 adaki2004 approved these changes

@Brechtpd Brechtpd Awaiting requested review from Brechtpd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @adaki2004 @davidtaikocha