feat(protocol): change to transfer-and-burn pattern with NFT vaults

[adaki2004]

To remove additional trust assumption, and do not allow vaults (if compromised) to arbitrarily burn tokens. Adapt the ‘transfer and burn’ pattern for NFTs as well (as we did for ERC20).

[openzeppelin-code]

feat(protocol): change to transfer-and-burn pattern with NFT vaults

Generated at commit: 67b945110d6c2a618f37be83f83f9613f8c236f6

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	2 2 0 6 41 51
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[dantaik]

@KorbinianK @cyberhorsey I think you guys need to know about this change (similar to what we did to BridgedERC20 vaults). Now you always have to get approvals first before burning bridged NFTs, just like what you do with canonical NFTs.

[adaki2004]

@KorbinianK @cyberhorsey I think you guys need to know about this change (similar to what we did to BridgedERC20 vaults). Now you always have to get approvals first before burning bridged NFTs, just like what you do with canonical NFTs.

@KorbinianK
Yes, so for bridged tokens, while bridging back we now require approve() for erc721 and setApprovalForAll() for erc1155.