Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): pause ERC20Vault by default on L2 so owner can deploy native USDC #16791

Merged
merged 1 commit into from
Apr 23, 2024
Merged

feat(protocol): pause ERC20Vault by default on L2 so owner can deploy native USDC #16791

merged 1 commit into from
Apr 23, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 22, 2024 •
edited
Loading

After a business conversation with Circle, we decided to deploy native USDC right after L2 genesis. This can be done by deploying the native USDC then call changeBridgedToken immediately after L2 genesis, then call unpause.

@dantaik dantaik marked this pull request as ready for review April 22, 2024 05:46
@dantaik dantaik requested a review from adaki2004 April 22, 2024 05:51
@openzeppelin-code OpenZeppelin Code
Copy link

feat(protocol): pause ERC20Vault by default on L2 so owner can init native USDC contract

Generated at commit: cbfcecff0a6b86242a71eae8e6a3ec6e86946b98

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
4
40
48
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik marked this pull request as draft April 22, 2024 06:01
@dantaik dantaik changed the title feat(protocol): pause ERC20Vault by default on L2 so owner can init native USDC contract feat(protocol): pause ERC20Vault by default on L2 so owner can deploy native USDC Apr 22, 2024
@dantaik dantaik marked this pull request as ready for review April 22, 2024 06:28
@davidtaikocha davidtaikocha added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit cd682a0 Apr 23, 2024
10 checks passed
@davidtaikocha davidtaikocha deleted the pause_erc20_vault_bydefault branch April 23, 2024 00:22
This was referenced Apr 23, 2024
Merged
Closed
@taiko-kitty taiko-kitty mentioned this pull request May 11, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@adaki2004 adaki2004 adaki2004 approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @Brechtpd @adaki2004 @davidtaikocha