Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): renounce timelock_admin role from msg.sender #16751

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

adaki2004
Copy link
Contributor

As per OZ finding:
kép

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
guardian-dashboard-hekla ✅ Ready (Inspect) Visit Preview Apr 16, 2024 3:00pm

@adaki2004 adaki2004 changed the title fix(protocol): revoke timelock_admin role from msg.sender fix(protocol): renounce timelock_admin role from msg.sender Apr 16, 2024
@adaki2004
Copy link
Contributor Author

@davidtaikocha
just my only question is that msg.sender is preserving the same context during foundry scripts, because renounceRole(role, address) can only work if address = msg.sender

@dantaik
Copy link
Contributor

dantaik commented Apr 17, 2024

@davidtaikocha just my only question is that msg.sender is preserving the same context during foundry scripts, because renounceRole(role, address) can only work if address = msg.sender

If it doesn't work, this function will revert.

@dantaik dantaik enabled auto-merge April 17, 2024 02:36
@dantaik dantaik added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit abd18e8 Apr 17, 2024
8 checks passed
@dantaik dantaik deleted the revoke_timelock_admin_role_msgSender branch April 17, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants