Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol): check invocation gas limit also in retryMessage #16660

Merged
merged 9 commits into from
Apr 5, 2024
Merged

fix(protocol): check invocation gas limit also in retryMessage #16660

merged 9 commits into from
Apr 5, 2024

Conversation

adaki2004
Copy link
Contributor

@dantaik dantaik changed the title fix(protocol): add check (during retry) not to supply less gas than initially specified fix(protocol): check invocation gas limit also in retryMessage Apr 5, 2024
@adaki2004 adaki2004 requested a review from dantaik April 5, 2024 08:46
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Apr 5, 2024 •
edited
Loading

fix(protocol): check invocation gas limit also in retryMessage

Generated at commit: 56b5529d65478504cd4c1e878c210d4c9b8b88d1

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
3
39
46
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@adaki2004 adaki2004 requested a review from dantaik April 5, 2024 09:29
@adaki2004 adaki2004 requested a review from dantaik April 5, 2024 09:29
@adaki2004 adaki2004 force-pushed the fix_gasLeft_supplied branch from d8e6be5 to 8f8af77 Compare April 5, 2024 09:53
@adaki2004 adaki2004 requested a review from dantaik April 5, 2024 09:53
@dantaik dantaik added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit 8209a43 Apr 5, 2024
6 checks passed
@dantaik dantaik deleted the fix_gasLeft_supplied branch April 5, 2024 13:22
This was referenced Apr 5, 2024
Closed
Merged
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantaik dantaik dantaik approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

@davidtaikocha davidtaikocha Awaiting requested review from davidtaikocha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adaki2004 @Brechtpd @dantaik