Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): remove and clear proposedIn from TaikoData.Block #16630

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 3, 2024

This proposedIn value is useless so I remove it and zero the field. The same slot can be used for other purposes in the future.

@dantaik dantaik requested review from Brechtpd and adaki2004 April 3, 2024 12:24
@dantaik dantaik marked this pull request as ready for review April 3, 2024 12:24
@dantaik dantaik requested a review from davidtaikocha April 3, 2024 12:24
Copy link

feat(protocol): remove and clear proposedIn from TaikoData.Block

Generated at commit: 2c542dacd5a5a97b070ab420da9a70b35efc3a96

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
3
39
46
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 511c18d Apr 4, 2024
11 checks passed
@dantaik dantaik deleted the remove_proposed_in branch April 4, 2024 01:34
dantaik added a commit that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants