fix(protocol): fix guardian prover #16606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code-423n4/2024-03-taiko-findings#248
Previous approvals are accumulated per
bytes32 hash = keccak256(abi.encode(_meta, _tran))
, and proof.data is totally ignored. Now we calculate hash askeccak256(abi.encode(_meta, _tran, _proof.data))
, this will enfore provers must have the same proof.data to decide if bonds are returned ( ifbytes32(_proof.data) == RETURN_LIVENESS_BOND
).