Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix guardian prover #16606

Merged
merged 5 commits into from
Apr 2, 2024
Merged

fix(protocol): fix guardian prover #16606

merged 5 commits into from
Apr 2, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 2, 2024

code-423n4/2024-03-taiko-findings#248

Previous approvals are accumulated per bytes32 hash = keccak256(abi.encode(_meta, _tran)), and proof.data is totally ignored. Now we calculate hash as keccak256(abi.encode(_meta, _tran, _proof.data)), this will enfore provers must have the same proof.data to decide if bonds are returned ( if bytes32(_proof.data) == RETURN_LIVENESS_BOND).

@dantaik dantaik marked this pull request as ready for review April 2, 2024 11:20
Copy link

openzeppelin-code bot commented Apr 2, 2024

fix(protocol): fix guardian prover

Generated at commit: 71d6ff8cfb48447eee595ecd4cb1ec718c418d35

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
3
39
46
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@davidtaikocha davidtaikocha added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 643bd17 Apr 2, 2024
10 checks passed
@davidtaikocha davidtaikocha deleted the improve_guardian branch April 2, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants