Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): remove banning address #16604

Merged
merged 3 commits into from
Apr 3, 2024
Merged

feat(protocol): remove banning address #16604

merged 3 commits into from
Apr 3, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 2, 2024

Banning an address serves as a preventative measure to restrict specific addresses from being targets of cross-message communication. Currently, I have not identified clear use cases for this feature. Considering that several auditors have inquired about which addresses should be banned, it may be prudent to eliminate this feature to prevent such recurring questions.

@dantaik dantaik requested review from adaki2004 and Brechtpd April 2, 2024 09:53
@dantaik dantaik marked this pull request as ready for review April 2, 2024 09:53
Copy link

openzeppelin-code bot commented Apr 2, 2024

feat(protocol): remove banning address

Generated at commit: 0d4135b22b96c0f000f8ce144b1a2997b79eab8b

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
3
39
46
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@adaki2004
Copy link
Contributor

Banning an address serves as a preventative measure to restrict specific addresses from being targets of cross-message communication. Currently, I have not identified clear use cases for this feature. Considering that several auditors have inquired about which addresses should be banned, it may be prudent to eliminate this feature to prevent such recurring questions.

It was (mainly) about SignalService, right ? Not to construct a fake message on behalf of the bridge.
For now it is safe to remove IMO, but we need to be careful when we:

  • Dont want bridge to be msg.sender: SignalService
  • We want bridge to be msg.sender: ERC20Vaults (see onlyFromBridge)

For now, i think it is safe.

@dantaik dantaik requested a review from davidtaikocha April 2, 2024 16:17
@dantaik dantaik enabled auto-merge April 3, 2024 03:21
@dantaik dantaik added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit c4b705b Apr 3, 2024
8 checks passed
@dantaik dantaik deleted the remove_address_banning branch April 3, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants