Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): upgrade to use OZ 4.9.6 #16360

Merged
merged 6 commits into from
Mar 9, 2024
Merged

feat(protocol): upgrade to use OZ 4.9.6 #16360

merged 6 commits into from
Mar 9, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Mar 8, 2024

No description provided.

@dantaik dantaik marked this pull request as ready for review March 8, 2024 13:52
@dantaik dantaik marked this pull request as draft March 8, 2024 13:56
@dantaik dantaik changed the title feat(protocol): upgrade to use OZ 4.9.3 feat(protocol): upgrade to use OZ 4.9.6 Mar 8, 2024
@dantaik dantaik marked this pull request as ready for review March 8, 2024 14:11
@adaki2004
Copy link
Contributor

adaki2004 commented Mar 8, 2024 •
edited
Loading

@dantaik We have gone through these (tho 4.9.5) and i guess code size (build fails) can be done and be inspired from these changes:
https://github.com/taikoxyz/taiko-mono/pull/15864/files

e.g.:

  • removed GovernorUpgradeable and GovernorVotesUpgradeable (since they are inherited through other contract e.g. Bravo)
  • removed __GovernorCompatibilityBravo_init(); (has no effect)
  • TaikoGovernor -> Taiko (every char is a byte)

@dionysuzx dionysuzx added this pull request to the merge queue Mar 9, 2024
Merged via the queue into main with commit 2a0fe95 Mar 9, 2024
10 checks passed
@dionysuzx dionysuzx deleted the oz-4.9.3 branch March 9, 2024 03:46
@taiko-kitty taiko-kitty mentioned this pull request Mar 9, 2024
Closed
This was referenced Mar 29, 2024
Closed
Closed
Closed
Closed
Merged
@taiko-kitty taiko-kitty mentioned this pull request Mar 29, 2024
Closed
This was referenced Apr 5, 2024
Closed
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dionysuzx dionysuzx dionysuzx approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

@adaki2004 adaki2004 Awaiting requested review from adaki2004

@davidtaikocha davidtaikocha Awaiting requested review from davidtaikocha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @adaki2004 @Brechtpd @dionysuzx