Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): allow one-tx claim and delegation for bridged ERC20 tokens #15727

Merged
merged 16 commits into from
Feb 11, 2024
Merged

feat(protocol): allow one-tx claim and delegation for bridged ERC20 tokens #15727

merged 16 commits into from
Feb 11, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 10, 2024

No description provided.

@dantaik dantaik marked this pull request as ready for review February 10, 2024 05:38
@dantaik dantaik mentioned this pull request Feb 10, 2024
Closed
Brechtpd
Brechtpd approved these changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@Brechtpd Brechtpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works, I would choose composition over inheritance here because I find it easier to follow, but not any real difference between the two: #15731.

@adaki2004 adaki2004 mentioned this pull request Feb 10, 2024
Merged
@dantaik dantaik enabled auto-merge (squash) February 11, 2024 02:11
@dantaik dantaik merged commit 603f24b into main Feb 11, 2024
6 of 13 checks passed
@dantaik dantaik deleted the claim_and_delegate branch February 11, 2024 06:38
@github-actions github-actions bot mentioned this pull request Feb 11, 2024
Merged
@taiko-kitty taiko-kitty mentioned this pull request Mar 1, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Mar 29, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 5, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 10, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adaki2004 adaki2004 adaki2004 approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @Brechtpd @adaki2004 @davidtaikocha